[ObjC] Rewrite Obj-C workflow in Rust#7299
Merged
Merged
Conversation
Contributor
Author
|
Having multiple different types of analysis of Perhaps there's some way I'm missing to communicate data between different activities that would allow me to have an "identify call sites" activity that call type adjustment and direct call rewriting activities could depend on so they could reuse data that it computes. |
emesare
reviewed
Aug 22, 2025
bdash
force-pushed
the
objc-workflow-rust
branch
2 times, most recently
from
f0ec045 to
46f325d
Compare
…value} These are available on `LowLevelILFunction<M, SSA>`.
1. Some SSA-specific functions are now implemented on `LowLevelILFunction<M, SSA>` rather than `Ref<LowLevelILFunction<M, SSA>>`. 2. A lifting helper for `LLIL_TAILCALL` is added to `LowLevelILFunction`. 3. `PossibleValueSet::ImportedAddressValue` now holds the value.
This is functionally equivalent to the previous workflow_objc, with the following changes: 1. It mutates the `core.function.metaAnalysis` workflow rather than registering a new named workflow. The activities now all check for the presence of the Objective-C metadata added by `ObjCProcessor` to determine whether they should do work, rather than relying on `MachoView` to override the function workflow when Objective-C metadata is present. This fixes #6779. 2. The auto-inlining of `objc_msgSend` selector stub functions is performed in a separate activity from the processing of `objc_msgSend` call sites. The selector stub inlining activity is configured so that it does not run in `DSCView` as the shared cache needs different behavior for stub functions more generally that `SharedCacheWorkflow` already provides. 3. The way that types like `id` and `SEL` are referenced is fixed so that they show up as `id` rather than `objc_struct*`. This also replaces the Objective-C portion of the shared cache's workflow, and incorporates several bug fixes that had been applied to it but not the standalone Objective-C workflow.
bdash
force-pushed
the
objc-workflow-rust
branch
from
46f325d to
2303f75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is functionally equivalent to the previous workflow_objc, with the following changes:
core.function.metaAnalysisworkflow rather than registering a new named workflow. The activities now all check for the presence of the Objective-C metadata added byObjCProcessorto determine whether they should do work, rather than relying onMachoViewto override the function workflow when Objective-C metadata is present. This fixes It should be easier to add additional activities to Objective-C and shared cache workflows #6779.objc_msgSendselector stub functions is performed in a separate activity from the processing ofobjc_msgSendcall sites. The selector stub inlining activity is configured so that it does not run inDSCViewas the shared cache needs different behavior for stub functions more generally thatSharedCacheWorkflowalready provides.idandSELare referenced is fixed so that they show up asidrather thanobjc_struct*.This also replaces the Objective-C portion of the shared cache's workflow, and incorporates several bug fixes that had been applied to it but not the standalone Objective-C workflow.